Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown alignment cells respect margin #36

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Markdown alignment cells respect margin #36

merged 1 commit into from
Apr 11, 2021

Conversation

shawalli
Copy link
Contributor

@shawalli shawalli commented Apr 10, 2021 •
edited
Loading

This PR updates the Markdown writer so that alignment cells use margins the same way that header and content cells do.

Closes #35.

@shawalli shawalli marked this pull request as ready for review April 10, 2021 01:01
thombashi
thombashi approved these changes Apr 11, 2021
View reviewed changes
Copy link
Owner

@thombashi thombashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thombashi thombashi merged commit f5baa2e into thombashi:master Apr 11, 2021
@thombashi
Copy link
Owner

Thank you for your pull request.

@hugovk hugovk mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thombashi thombashi thombashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Markdown table alignment row to conform to GFM
2 participants
@shawalli @thombashi