Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement track addresses in RegionalMuonCand RawDigi translator #2

Closed
thomreis opened this issue Nov 4, 2015 · 7 comments
Closed

Implement track addresses in RegionalMuonCand RawDigi translator #2

thomreis opened this issue Nov 4, 2015 · 7 comments
Labels
enhancement refactoring

Comments

@thomreis
Copy link
Owner

thomreis commented Nov 4, 2015

Implement EMTF track addresses in RegionalMuonCand RawDigi translator and change existing BMTF address scheme to the new one with four candidates.
@thomreis
Copy link
Owner Author

thomreis commented Nov 9, 2015

BMTF segment selector added with PR cms-l1t-offline#88

@thomreis
Copy link
Owner Author

BMTF track addresses were wrongly ordered in the interface note. St. 4,3,2,1 should be St. 1,2,3,4.

Like this the sub addresses are aligned with the nibble boundaries.

@thomreis
Copy link
Owner Author

cms-l1t-offline#99 had the correct BMTF track address format.

@thomreis
Copy link
Owner Author

thomreis commented Jan 6, 2016

The selector field for segments 0, 1 or 2, 3 is still missing.

@thomreis
Copy link
Owner Author

included in PR cms-l1t-offline#133 and cms-l1t-offline#127

@thomreis
Copy link
Owner Author

EMTF track address still missing

@thomreis
Copy link
Owner Author

thomreis commented Feb 4, 2016

A proposal for EMTF track addresses is in cms-l1t-offline#138

@thomreis thomreis closed this as completed Feb 4, 2016
thomreis pushed a commit that referenced this issue Oct 4, 2016
@smorovic
fix indentation #2
c0fbc6f
thomreis pushed a commit that referenced this issue Oct 12, 2016
@smorovic
fix indentation #2
806b470
thomreis pushed a commit that referenced this issue Mar 16, 2017
@amarini
Merge pull request #2 from amarini/topic_simclustering2
e8fd570 
Topic simclustering2
thomreis pushed a commit that referenced this issue May 2, 2017
Add missing virtual dtors #2
04a4375 
CMSSW GCC 7.0.1 builds now follows jemalloc (dev branch) and also has a
new TCMalloc. Both of these have C++14 sized deallocation feature
enabled. This means that if possible operator delete will be called with
size argument, which will help allocator to reduce the time to free the
object. E.g. this is not possible for incomplete types which size is
unknown at a time.

GCC 7.0.1 builds contain an additional build of jemalloc
(jemalloc-debug) which contains extra asserts and checks for developers.

This seems to be undefined behavior in C++14. From [expr.delete] (5.3.5
Delete):

    In the first alternative (delete object), if the static type of the
    object to be deleted is different from its dynamic type, the static type
    shall be a base class of the dynamic type of the object to be deleted
    and the static type shall have a virtual destructor or the behavior is
    undefined.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
thomreis pushed a commit that referenced this issue May 2, 2017
@davidlange6
Merge pull request cms-sw#18273 from davidlt/virt-dtors-2
1e68936 
Add missing virtual dtors #2
thomreis pushed a commit that referenced this issue May 10, 2017
@sunilUIET
Merge pull request #2 from aminnj/csc-aging-integration_90X_v1
36b7f40 
CSC aging integration for 90X
thomreis pushed a commit that referenced this issue May 10, 2017
@bapavlov
Merge pull request #2 from bapavlov/revert-1-LinkBoard_upgrade
28d63da 
Revert "remove customization function for redigi"
thomreis pushed a commit that referenced this issue May 19, 2017
@davidlange6
Merge pull request cms-sw#18734 from forthommel/ctpps-runranges_patch…
cfa9831 
…2-9_2_X

CTPPS: bug fix #2 in run ranges for FEDs channels mapping (9_2_X)
thomreis pushed a commit that referenced this issue Aug 2, 2017
@anigamova
Merge pull request #2 from anigamova/new_branch
9923022 
New branch
thomreis pushed a commit that referenced this issue Aug 2, 2017
@jaehyeok
Merge pull request #2 from kpedro88/update-HcalSeverityLevelComputer-…
7f06d21 
…phase1

Add filldescriptions and remove warning
thomreis pushed a commit that referenced this issue Aug 2, 2017
@cmsbuild
Merge pull request cms-sw#19743 from abrinke1/EMTF_PR_2017_93X_part2
45bbf71 
EMTF 2017 PR #2 - 2017 DataFormats
thomreis pushed a commit that referenced this issue Nov 21, 2019
@jaimeleonh
Merge pull request #2 from jaimeleonh/debugChange
b26fdc3 
Some changes in test files
thomreis pushed a commit that referenced this issue Mar 2, 2020
@tvami
Merge pull request #2 from mmusich/addSiPixelCalCosmics_onTop_ofTamasPR
4e4cefe 
Add SiPixelCalCosmics on top of PR cms-sw#28574
thomreis pushed a commit that referenced this issue Apr 20, 2020
@skinnari
Merge pull request #2 from skinnari/L1TK_CMSSW_11-1-0-pre4
2eccc68 
port recent changes from gitlab
thomreis pushed a commit that referenced this issue Apr 20, 2020
@duartej
Merge pull request #2 from mmusich/inclusionOf3DPixelsIntoCMSSW
0c1871c 
address remaining stylistic comments from code review
thomreis pushed a commit that referenced this issue Nov 23, 2020
@alefisico
Merge pull request #2 from alefisico/PUPPIMETwithPUPPIV15_v2
4b072e0 
fix bug
thomreis pushed a commit that referenced this issue Nov 24, 2020
@lecriste
Merge pull request #2 from amartelli/timeForMerged_11_2_X_forLeo
6f18708 
Time for merged tracksters
thomreis pushed a commit that referenced this issue Nov 25, 2020
@jsalfeld
Merge pull request #2 from mmasciov/mmasciovScoutingMuonRun3Format
72d1243 
Fix code formatting according to scram build code-format
thomreis pushed a commit that referenced this issue Feb 2, 2021
@SohamBhattacharya
Merge pull request #2 from Sam-Harper/HGCal_ShowerShapes_11_1_6
5b9c219 
adding HGCalClusterTools and HGCalID variable producer
thomreis pushed a commit that referenced this issue Sep 2, 2021
@iarspider
code-format #2
64de4e1
thomreis pushed a commit that referenced this issue Jun 10, 2022
@ThOliveira23
Merge pull request #2 from ThOliveira23/from-CMSSW_12_4_0_pre4
abd6365 
First test
thomreis pushed a commit that referenced this issue Jun 15, 2023
@aloeliger
Merge pull request #2 from EmyrClement/bTagNN_addExtSCJets_master
75130d6 
Add SC jets from extended tracks to event content.
thomreis pushed a commit that referenced this issue Jun 15, 2023
@AnnikaStein @smuzaffar
@cmsbuild @mmusich @aloeliger
merge from master (#2)
7ce96e9 
* added EXOLLPJetHCAL skim (initial version)

* added test script test_EXOLLPJetHCAL_SKIM.py

* Replace cout with edm::Logverbatim in Geometry/GlobalTrackingGeometryBuilder

* Re-enable unit tests for ASAN build

* dd4hep phase2 wf

* Add wf *.81 for BPH DQM

* Added utility script edmFileInPath

* improve unt test; use edmFileInPath; convert to bash

* Replace std::cout with edm::LogVerbatim in Geometry/HcalEventSetup and Geometry/HcalTestBeamData. Also add some missing files needed for testing

* Code check

* Remove FWCore TestHelper utility

* Add ap_data type for GT interface

Update GMT emulator for new ap format

Also clean up the config file

Update Z0/D0 according to GT

Using 0.05 for Z0 and 0.03 for d0.

update code format

Bug fix in tracker muon matching

Thanks to Santi for spotting this. This line was commented out by
someone, likely by accident.

Update the reference type to SA muons

* improve unit test testCreateRandomMisalignment

* Add back removed data version

* fix bug in computation of barycenters per partition and improve graphical display

* get rid of gROOT->Reset() in GeometryComparisonPlotter.cc

---------

Co-authored-by: Kiley Kennedy <kiley.elizabeth.kennedy@cern.ch>
Co-authored-by: Sunanda <sunanda.banerjee@cern.ch>
Co-authored-by: Shahzad Malik Muzaffar <shahzad.malik.muzaffar@cern.ch>
Co-authored-by: Norraphat <srimanob@mail.cern.ch>
Co-authored-by: AdrianoDee <adriano.diflorio@ba.infn.it>
Co-authored-by: Zhenbin Wu <zhenbin.wu@gmail.com>
Co-authored-by: cmsbuild <cmsbuild@cern.ch>
Co-authored-by: mmusich <marco.musich@cern.ch>
Co-authored-by: Andrew David Loeliger <andrew.loeliger@cern.ch>
thomreis pushed a commit that referenced this issue Jun 15, 2023
@elfontan
Merge pull request #2 from arnobaer/muon_index_cut
16a6d2c 
Muon index cut
thomreis pushed a commit that referenced this issue Jun 15, 2023
@epalencia
Merge pull request #2 from folguera/FixTo_epalencia_l1t-1109_v3
53419b9 
Fix to l1t-1109_v3
thomreis pushed a commit that referenced this issue Jul 7, 2023
@dbruschi
Merge pull request #2 from cms-sw/master
26aee51 
Merge from cmssw master
thomreis pushed a commit that referenced this issue Mar 4, 2024
@noepalm
Squashed commit of the following:
b2a7305 
commit a7454c6
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 12 14:22:51 2024 +0100

    Updated binning for sigma(TOF) validation histograms

    Updated binning for sigma(TOF) validation histograms

    Updated binning for sigma(TOF) validation histograms

commit e0dc3be
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 16:40:42 2024 +0100

    Code checks && format (#2)

commit 7c70ed8
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 15:57:59 2024 +0100

    Removed debug ifdef condition on print to match previous implementation

commit 2e40a9f
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 15:54:41 2024 +0100

    Removed useless comments, files + fixed input file path for standalone MTD validation cfg file

commit 199ad72
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 14:41:57 2024 +0100

    Code checks && code format

commit 6ec3c46
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Tue Feb 6 09:56:49 2024 +0100

    Changed SigmaTof fill location in validation

commit 6a0525e
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 5 18:11:27 2024 +0100

    Change input file to validation

commit cb7db5b
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 5 18:07:19 2024 +0100

    Saving sigmaTOF in ps

commit 00230ac
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 5 15:32:11 2024 +0100

    Removed useless prints + created member vector in TrackSegments to allocate memory for sigmaTof once

commit fdd6e31
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Tue Jan 9 16:08:46 2024 +0100

    Added sigma(p) to TrackSegments; added sigma(TOF) computation, now saved to event

commit 7d488e0
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Dec 6 14:24:26 2023 +0100

    testing files

commit 88f9847
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 12 12:42:15 2024 +0100

    Replaced isnan, isinf with edm::isNotFinite in MTD vertex validation
thomreis pushed a commit that referenced this issue Jun 6, 2024
@omiguelc
Merge pull request #2 from watson-ij/l1t-pr-fixes
48b6441 
L1T GE0 fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomreis