Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing the FAQ-text directly in the notification-mail #2394

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Showing the FAQ-text directly in the notification-mail #2394

merged 5 commits into from
Mar 27, 2023

Conversation

modelrailroader
Copy link
Contributor

If you want to implement this as well to ver3.2-alpha, here is the code.
This would fix issue #2392
This shows the full question and answer of the new faq directly in the notification email which is sent to the moderators when a new faq is created. I think this will make it more practical.

Added support for showing the full question and answer of the faq directly in the email
Added support for showing the faq text directly in the notification-mail.
Added support for showing the faq text directly in the notification-mail.
$this->mail->message = html_entity_decode(
Translation::get('msgMailCheck')
) . "\n\n" . $this->config->getTitle() . ': ' . $this->config->getDefaultUrl(
) . 'admin/?action=editentry&id=' . $faqId . '&lang=' . $faqLanguage;
) . "<p><strong>Frage:</strong> " . $this->faq->getRecordTitle($faqId) . "</p>"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A translation is missing for "Frage", you can use Translation::get('msgAskYourQuestion')

@thorsten thorsten merged commit 1614645 into thorsten:main Mar 27, 2023
@thorsten
Copy link
Owner

Thank you very much!

@modelrailroader modelrailroader deleted the patch-1 branch May 27, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants