Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svg_loader: copy the use node properties #1452

Merged
merged 1 commit into from
May 16, 2023
Merged

svg_loader: copy the use node properties #1452

merged 1 commit into from
May 16, 2023

Conversation

mgrudzinska
Copy link
Collaborator

A bug was observed when a 'use' node was
referenced in another 'use' node.

@issue: #1451

sample:

<svg viewBox="0 0 80 20" xmlns="http://www.w3.org/2000/svg">

  <use id="a" href="#myDot" x="5" y="5" style="fill:red" />  
  <use href="#a" x="20" y="5" style="fill:blue; opacity:0.4" />

  <symbol id="myDot" width="10" height="10" viewBox="0 0 2 2">
    <circle cx="1" cy="1" r="1" />
  </symbol>
</svg>

before:
Zrzut ekranu 2023-05-16 o 01 01 39

after:
Zrzut ekranu 2023-05-16 o 01 01 59

@mgrudzinska
svg_loader: copy the use node properties
0ecf021 
A bug was observed when a 'use' node was
referenced in another 'use' node.

@issue: thorvg#1451
@mgrudzinska mgrudzinska added bug Something isn't working svg SVG features labels May 15, 2023
@mgrudzinska mgrudzinska self-assigned this May 15, 2023
@mgrudzinska mgrudzinska requested a review from JSUYA as a code owner May 15, 2023 23:31
@mgrudzinska mgrudzinska mentioned this pull request May 15, 2023
Closed
JSUYA
JSUYA approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hermet hermet merged commit 40ef903 into thorvg:master May 16, 2023
@clemens-tolboom clemens-tolboom mentioned this pull request May 17, 2023
Closed
@mgrudzinska mgrudzinska deleted the mgrudzinska/use1 branch April 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSUYA JSUYA JSUYA approved these changes

Assignees

@mgrudzinska mgrudzinska

Labels
bug Something isn't working svg SVG features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgrudzinska @JSUYA @hermet