feat: add support for losslessOption
#200
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to support lossless option.
With the current implementation of Thoth.json,
None
orSome (Some None)
are both encoded hasnull
.This PR introduce 2 new API:
lossyOption
: is equivalent to the oldoption
APIlosslessOption
which is able to differentiate the nested optionsWarning
The old
Decode.option
andEncode.option
will be completely removed. People, will need to manual path their code to use thelossyOption
API.I am removing the API completely because the API changes only impact the new version of Thoth.Json, so this is I believe the perfect moment to do it instead of introducing an
Obsolete
warning to be removed later on.If you think differently please voice int
If we agree on the implementation, we will need to also change the
object
builder API to reflect this changes too.