Make TransactionSearchResponse.Data.Fields a json.RawMessage #23
Conversation
The present keys and value types change depending on the transaction,
and using json.RawMessage allows it to be mapped to an appropriate
struct once they type is known rather than needing to fish the values
out of a messy map of interface{}.
This is certainly a breaking change for any consumers of Fields, but
one that should be easy to identify at compile time, and can be fixed
with a simple json.Marshal call.
|
Stale pull request message |
|
Sorry, this one slipped by me at the time... Let me check internally about how we use this and what it'd mean. TBH I wonder if really there should be concrete types for each SearchResponse struct... |
|
+1 on adding the concrete types. This is the way that the upstream does it, so we might end up with conflicts. Can see why you've taken this approach though. |
|
I think that's the direction we should take. If we're going to break compatibility with these messages (something I am not against in general, we use this in a relatively limited set of places internally and I'm not sure there are many other people using it) I think I'd rather do it "properly" to get to the better possible end state. Thanks for the pull request anyway! |
The present keys and value types change depending on the transaction,
and using json.RawMessage allows it to be mapped to an appropriate
struct once they type is known rather than needing to fish the values
out of a messy map of interface{}.
This is certainly a breaking change for any consumers of Fields, but
one that should be easy to identify at compile time, and can be fixed
with a simple json.Marshal call.