Support Sprockets 4 #1452
Merged
Support Sprockets 4 #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module '@thoughtbot/eslint-config'
Cannot find module '@thoughtbot/eslint-config'
Referenced from: .eslintrc
Error: Cannot find module '@thoughtbot/eslint-config'
at ModuleResolver.resolve (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:479:28)
at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:551:26)
at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
at Array.reduceRight ()
at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)
at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:523:22)
at Object.load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:179:43)
|
Argh, the build fails because of the security advisory on loofah. Both #1449 and this need to go through together for the build to pass. |
Closed
This fixes CI, which is currently failing for all appraisals with the
following error:
```
Sprockets::Railtie::ManifestNeededError:
Expected to find a manifest file in `app/assets/config/manifest.js`
But did not, please create this file and use it to link any assets that need
to be rendered by your app:
Example:
//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css
```
This is due to Sprockets 4, which requires this `manifest.js` file. Sprockets
4 was published on 8 October 2019, the day after the last successful build.
From what I can tell, the only fix is having the client app listing
Administrate's asset files in its `manifest.js` file. Therefore I'm creating
one for the example app (used in the specs) and documenting this extra manual
work in the README.
For some detail on this manifest file, see
https://www.schneems.com/2017/11/22/self-hosted-config-introducing-the-sprockets-manifestjs/
If you run the specs locally with `bundle exec rake`, they'll probably pass.
This is because the bundled `Gemfile.lock` has Sprockets pinned to version
3.7.2 currently. However if you run the appraisal specs with
`bundle exec appraisal rake`, these may fail because the appraisal lockfiles
are not under version control, and therefore will be regenerated on first run.
Note that a newly created Rails app won't have this issue at the time being.
This is because Rails apps are still being generated to use the `sass` gem
(despite its being end-of-life'd) and this depends on `sprockets < 4`. Using
`sassc` in your app may land you Sprockets 4 though (you'd still have to
explicitly `bundle update` to get it).
I don't see a way to have Administrate provide an engine-level `manifest.js`
instead of having the client application manually add it. I might be missing
something though.
Another option would be having the Administrate generator add the required
lines to the manifest files. I think we'd still have to document it in the
README, as that's bound to not be enough for many.
nickcharlton
force-pushed
the
sprockets-4
branch
from
36c5734
to
a331659
Compare
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module '@thoughtbot/eslint-config'
Cannot find module '@thoughtbot/eslint-config'
Referenced from: .eslintrc
Error: Cannot find module '@thoughtbot/eslint-config'
at ModuleResolver.resolve (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:479:28)
at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:551:26)
at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
at Array.reduceRight ()
at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)
at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:523:22)
at Object.load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:179:43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR should fix the CI build, which is currently failing for all appraisals with the following error:
Details
This is due to Sprockets 4, which requires this
manifest.jsfile. Sprockets 4 was published on 8 October 2019, the day after the last successful build.From what I can tell, the only fix is having the client app listing Administrate's asset files in its
manifest.jsfile. Therefore I'm creating one for the example app (used in the specs) and documenting this extra manual work in the readme.For some detail on this manifest file, see https://www.schneems.com/2017/11/22/self-hosted-config-introducing-the-sprockets-manifestjs/
But it passes on my machine!
If you run the specs locally with
bundle exec rake, they'll probably pass. This is because the bundledGemfile.lockhas Sprockets pinned to version 3.7.2 currently. However if you run the appraisal specs withbundle exec appraisal rake, these may fail because the appraisal lockfiles are not under version control, and therefore will be regenerated on first run.Note that a newly created Rails app won't have this issue at the time being. This is because Rails apps are still being generated to use the
sassgem (despite its being end-of-life'd) and this depends onsprockets < 4. Usingsasscin your app may land you Sprockets 4 though (you'd still have to explicitlybundle updateto get it).Future options
I don't see a way to have Administrate provide an engine-level
manifest.jsinstead of having the client application manually add it. I might be missing something though.Another option would be having the Administrate generator add the required lines to the manifest files. I think we'd still have to document it in the readme, as that's bound to not be enough for many.