Command determines ARGV correctly when ARGV empty #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually if you call `rake appraisal` from a project configured to use Appraisal, then everything works -- Appraisal calls `rake` for each of your gemfiles. However, if you've configured `rake` to run `rake appraisal` automatically, when you call `rake` then Appraisal::Command throws an error. This is because it assumes that "appraisal" will be first in ARGV, which is the case when you call `rake appraisal` manually but not the case here. Therefore when it tries to figure out which command to run it blows up (as ARGV[1..-1] returns nil if ARGV is empty). This commit fixes that.
This was referenced Aug 16, 2013
|
For some reason, this commit halts Travis build. I think it's actually safe to just call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually if you call
rake appraisalfrom a project configured to use Appraisal, then everything works -- Appraisal callsrakefor each of your gemfiles.However, if you've configured
raketo runrake appraisalautomatically, when you callrakethen Appraisal::Command throws an error. This is because it assumes that "appraisal" will be first in ARGV, which is the case when you callrake appraisalmanually but not the case here. Therefore when it tries to figure out which command to run it blows up (as ARGV[1..-1] returns nil if ARGV is empty). This commit fixes that.NOTE: I'm not sure how to test this? Is there a way?