Make small changes and additions to variables #80
Conversation
kylefiedler
commented
Jun 17, 2014
kylefiedler
commented
- Rearrange size variables
- Add z-index variables
- Make header-line-height unitless
| $unitless-header-line-height: $header-line-height / ($header-line-height * 0 + 1); // Strip units from line-height: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values | ||
|
|
||
| // Other Sizes | ||
| $base-border-radius: em(3); |
There was a problem hiding this comment.
This is one of the few dimensions that I like a consistent value that's not relative to font-size. Maybe rem(3)?
There was a problem hiding this comment.
rem(3) would also force Bourbon 4.0 and Sass 3.3.
I get what you are saying though. If someone bumps up the font size you don't want the radius to change. 3rem or 3px?
There was a problem hiding this comment.
I'd prefer 3px to em(3). Like if code has a $small-font-size and a border with radius, it's no longer consistent with the rest of the app.
There was a problem hiding this comment.
👍 I much prefer border radius to be specified in pixels.
|
👍 Wish 3.3 everywhere. |
| @@ -6,14 +6,14 @@ table { | |||
| } | |||
|
|
|||
| th { | |||
| border-bottom: 1px solid darken($base-border-color, 15%); | |||
| border-bottom: 1px solid darken($base-border-color, 15); | |||
There was a problem hiding this comment.
It's fine if deliberate, but these don't output the same values.
|
💸 |
| // Line height | ||
| $base-line-height: $base-font-size * 1.5; | ||
| $unitless-line-height: $base-line-height / ($base-line-height * 0 + 1); // Strip units from line-height: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values | ||
| $header-line-height: $base-font-size * 1.25; |
There was a problem hiding this comment.
Where do see this being used now that there is $unitless-header-line-height? I feel as though the line-heights are getting overly complicated.
|
Merge, merge, merge 😃 |
* Rearrange size variables * Add z-index variables * Make header-line-height unitless
