This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Fix font-url for sass-rails > 5.x
#617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using newer versions of `sass-rails`, the `$asset-pipeline` flag wasn't working properly. Although the `font-url` asset helper from `sass-rails` was being generated into the resulting CSS, it was not being post-processed by the asset pipeline. The way we were previously outputting the `font-url` caused `sass-rails` to not recognize the `font-url` helper. This change appends the helper in a more direct way, and this resolves the issue. Fixes #603
|
Whew, that was a tough one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using newer versions of
sass-rails, the$asset-pipelineflag wasn'tworking properly. Although the
font-urlasset helper fromsass-railswas being generated into the resulting CSS, it was not beingpost-processed by the asset pipeline.
The way we were previously outputting the
font-urlcausedsass-railstonot recognize the
font-urlhelper. This change appends the helper in a moredirect way, and this resolves the issue.
Fixes #603