Redirect back to blog post after authing via GitHub

[mxie]

After clicking "Leave a note", a new window popped up asking me sign in or auth through GitHub. After doing so, I was redirected to my Learn timeline (within this same popup), which I find a bit odd.

I expected to be signed in (after I give my permission) and have the popup closed automatically so that I can go back to trying to leave a note.

[cpytel]

I think this is a bug in Learn for github based login. Did you login with
GitHub or with a username and password? Thanks.

On May 17, 2014, at 6:22 AM, Melissa Xie notifications@github.com wrote:

After clicking "Leave a note", a new window popped up asking me sign in or
auth through GitHub. After doing so, I was redirected to my Learn timeline
(within this same popup), which I find a bit odd.

I expected to be signed in (after I give my permission) and have the popup
closed automatically so that I can go back to trying to leave a note.

Reply to this email directly or view it on
GitHubhttps://github.com//issues/39
.

[mxie]

@cpytel I logged in through GitHub.

[cpytel]

Ok, this has actually been a known issue on Learn for some time, the bug is logged here https://www.apptrajectory.com/thoughtbot/learn/stories/15632156

It would be great to get that addressed soon.

[cpytel]

Ok, I fixed this bug in Learn and it is deployed. You shouldn't have this problem now, if you could give it another try I'd appreciate it. Thanks!

[pbrisbin]

Closing. Please reopen is this is still an issue.

[mxie]

So I'm not sure if this is something we can control, but I tried revoking the access, and it still allows me to leave a note, so I can't actually try this out again. Any ideas? Maybe we have to reach into the database.