Skip to content
This repository has been archived by the owner on Nov 18, 2017. It is now read-only.

Enable for mobile views and skinny browsers #57

Closed
cpytel opened this issue Jun 6, 2014 · 4 comments
Closed

Enable for mobile views and skinny browsers #57

cpytel opened this issue Jun 6, 2014 · 4 comments

Comments

@cpytel
Copy link
Member

cpytel commented Jun 6, 2014

Right now we disable Carnival on anything less than 760px wide.

I would like to eventually enable comment viewing and commenting for mobile devices and skinny browsers.

@cpytel
Copy link
Member Author

cpytel commented Oct 17, 2014

Oh hey, this is done in #111.

It is deployed to staging for acceptance:
http://staging.robots.thoughtbot.com/functional-swift-for-dealing-with-optional-values

@cpytel
Copy link
Member Author

cpytel commented Oct 17, 2014

To close on mobile, click the comment indicator again (just like on Desktop).

On mobile, its possible to scroll away from it, so its not ideal, but I decided it was good enough for now.

@jferris
Copy link
Contributor

jferris commented Oct 24, 2014

Agreed that this is good enough. I could read comments and respond to them. Looks like there isn't a way to leave comments on new section on mobile, but I think that's fine for now.

@cpytel
Copy link
Member Author

cpytel commented Oct 24, 2014

Deployed to production.

@cpytel cpytel closed this as completed Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants