Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with text for installing on m1 macs #18

Closed
wants to merge 1 commit into from

Conversation

brian-penguin
Copy link
Contributor

No description provided.

@joshuaclayton
Copy link
Contributor

@brimatteng I'm wondering if we should instead default to the Rust allocator and have people opt-in. That way, OOTB it'll work both on Intel and Apple Silicon. The perf bump is nice, but on the majority of projects should be sub-5s on new-ish hardware anyways. What do you think?

@brian-penguin
Copy link
Contributor Author

It's probably better to pass a flag and have it "work" by default, I didn't notice that much real difference in build time between the two branches

@joshuaclayton
Copy link
Contributor

@brimatteng I've attempted to address this indirectly by updating our Homebrew formula to opt-in to MiMalloc here.

@joshuaclayton
Copy link
Contributor

@brimatteng I've merged the update to our Homebrew formula, so the stock brew install complexity should now work regardless of architecture.

I'm thinking that we can close this without merging, but will leave that to you to confirm. Thanks for flagging!

@brian-penguin
Copy link
Contributor Author

I'm good with closing it. Thanks for updating

@joshuaclayton joshuaclayton deleted the bt/readme-updates branch October 1, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants