Remove support for configuring validation options #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
remove-support-for-options
branch
2 times, most recently
from
bbfddc3
to
5d98c96
Compare
mike-burns
reviewed
Apr 13, 2018
|
@mike-burns I like that idea! I've opened #78. Once that's ready to go, how would you suggest we version that release? The current version is |
seanpdoyle
force-pushed
the
remove-support-for-options
branch
from
5d98c96
to
a228105
Compare
houndci-bot
reviewed
Apr 13, 2018
lib/json_matchers/rspec.rb
Outdated
|
|
||
| assertion = JsonMatchers::Assertion.new(schema_name.to_s, options) | ||
|
|
||
| RSpec::Matchers.define :match_json_schema do |schema_name| |
There was a problem hiding this comment.
Lint/UnusedBlockArgument: Unused block argument - schema_name. You can omit the argument if you don't care about it.
seanpdoyle
force-pushed
the
remove-support-for-options
branch
from
a228105
to
9f0bb94
Compare
In preparation for [#31][#31], this commit removes support for global and matcher-specific options, like `strict: true`. The [`json_schema` gem][gem] does not accept similar configuration options, so we'll remove support entirely. [#31]: #31 [gem]: https://github.com/brandur/json_schema#programmatic
seanpdoyle
force-pushed
the
remove-support-for-options
branch
from
9f0bb94
to
48e7620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #31, this commit removes support for global
and matcher-specific options, like
strict: true.The
json_schemagem does not accept similar configurationoptions, so we'll remove support entirely.