Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for configuring validation options #78

Closed
wants to merge 0 commits into from

Conversation

seanpdoyle
Copy link
Collaborator

In preparation for #31, this commit deprecates support for global
and matcher-specific options, like strict: true.

The json_schema gem does not accept similar configuration
options, so in the future we'll need to remove support entirely.

@@ -1,3 +1,3 @@
module JsonMatchers
VERSION = "0.8.0"
VERSION = "0.9.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/MutableConstant: Freeze mutable objects assigned to constants.

Copy link

@mike-burns mike-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what it means for me to ask this: do we want to use ActiveSupport::Deprecation?

@seanpdoyle
Copy link
Collaborator Author

@mike-burns in order to use ActiveSupport::Deprecation, we'd have to add a dependency on activesupport.

Right now, activesupport is only a development dependency.

What does ActiveSupport::Deprecation provide that is an improvement on warn?

@mike-burns
Copy link

AS::Deprecation warnings can be silenced the same way any other Rails deprecation notice can, whereas warn requires -W0 to silence it.

If we don't depend on AS, then let's not add it just for this.

@seanpdoyle seanpdoyle closed this Apr 13, 2018
@seanpdoyle seanpdoyle force-pushed the deprecate-support-for-options branch from 5de341a to f840139 Compare April 13, 2018 19:16
@seanpdoyle seanpdoyle deleted the deprecate-support-for-options branch April 13, 2018 19:16
@seanpdoyle
Copy link
Collaborator Author

Merged in f840139.

@seanpdoyle seanpdoyle changed the title Remove support for configuring validation options Deprecate support for configuring validation options Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants