Don't open browser

[croaky]

• Opening the browser can surprise people.
• Use gerund in nearby command output.

[djcp]

Is it even worth it to generate the ssh key?

[Kerrick]

@djcp

Is it even worth it to generate the ssh key?

Probably not.

With this commit, Github is never opened to the SSH keys page, so an SSH key is generated just to sit there. In order to put it into Github, the user has to go copy/paste the keys in anyways, so we're only saving them half a step by generating SSH keys.

Plus, not everybody wants to generate a new SSH key for every machine. I personally carry around my SSH and PGP keys on an encrypted flash drive, and symlink the folders in the encrypted mount point to my ~/.ssh and ~/.gpg directories. Of course, laptop doesn't overwrite existing keys, so it's not that big of a problem to generate them anyways--just an extra check and step.

A bigger problem is that the SSH key generation provides a captive interface, and if the user simply presses enter to get through it quickly, the SSH key will not have a passphrase. The ssh-keygen utility doesn't stress the importance of a passphrase, it's quite blasé about it.

Enter passphrase (empty for no passphrase):

As it stands, Github has the following on their SSH keys page in your account settings anyways--and they stress the importance of a good passphrase. Laptop isn't saving any hassle by generating the SSH keys, just possibly saving a few lines typed into a terminal.

Need help? Check out our guide to generating SSH keys or troubleshoot common SSH Problems

[croaky]

@djcp @Kerrick Good point. Removed ssh-keygen in follow-up commit.

Ready for another review.

[Kerrick]

[croaky]

Thanks, Kerrick. Merged.