Don't open browser #86

Merged
merged 1 commit into from Apr 10, 2013

Projects

None yet

4 participants

Owner
croaky commented Apr 9, 2013
  • Opening the browser can surprise people.
  • Use gerund in nearby command output.
Contributor
djcp commented Apr 9, 2013

Is it even worth it to generate the ssh key?

Contributor
Kerrick commented Apr 9, 2013

@djcp

Is it even worth it to generate the ssh key?

Probably not.

With this commit, Github is never opened to the SSH keys page, so an SSH key is generated just to sit there. In order to put it into Github, the user has to go copy/paste the keys in anyways, so we're only saving them half a step by generating SSH keys.

Plus, not everybody wants to generate a new SSH key for every machine. I personally carry around my SSH and PGP keys on an encrypted flash drive, and symlink the folders in the encrypted mount point to my ~/.ssh and ~/.gpg directories. Of course, laptop doesn't overwrite existing keys, so it's not that big of a problem to generate them anyways--just an extra check and step.

A bigger problem is that the SSH key generation provides a captive interface, and if the user simply presses enter to get through it quickly, the SSH key will not have a passphrase. The ssh-keygen utility doesn't stress the importance of a passphrase, it's quite blasé about it.

Enter passphrase (empty for no passphrase):

As it stands, Github has the following on their SSH keys page in your account settings anyways--and they stress the importance of a good passphrase. Laptop isn't saving any hassle by generating the SSH keys, just possibly saving a few lines typed into a terminal.

Need help? Check out our guide to generating SSH keys or troubleshoot common SSH Problems

@croaky croaky Don't open browser
* Opening the browser can surprise people.
* Use gerund in nearby command output.
d83acaa
Owner
croaky commented Apr 10, 2013

@djcp @Kerrick Good point. Removed ssh-keygen in follow-up commit.

Ready for another review.

Contributor
Kerrick commented Apr 10, 2013

:shipit:

@croaky croaky merged commit d83acaa into master Apr 10, 2013
Owner
croaky commented Apr 10, 2013

Thanks, Kerrick. Merged.

Tangential: I'm curious as to why ssh generation was removed.

Owner

I think my thought was that without pointing people toward GitHub, they may not know it was created or to use it on GitHub. So, when they go to do it, they may end up repeating the whole process anyway.

@djcp What do you think about bringing SSH generation back without the pasteboard copy and browser open? Maybe print those second and third steps to the shell as instructions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment