This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
Order main.go by vars, funcs, types #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func stripPodcastEpisodePrefix(s string) string { | ||
| return podcastEpisodePrefix.ReplaceAllString(s, "") | ||
| } | ||
|
|
||
| type byCreated []*feeds.Item |
There was a problem hiding this comment.
I think this should still be on top of the byCreated methods.
|
One comment. Looks great! 👍 |
| {uri: "http://simplecast.fm/podcasts/282/rss", name: "The Bike Shed podcast"}, | ||
| {uri: "http://simplecast.fm/podcasts/1088/rss", name: "Tentative podcast"}, | ||
| {uri: "https://upcase.com/the-weekly-iteration.rss", name: "The Weekly Iteration videos"}, | ||
| } |
There was a problem hiding this comment.
@bernerdschaefer is it more idiomatic for this to be a constant?
There was a problem hiding this comment.
If the value were a string or number, then probably so. But slices can't be constants, so var is correct.
This is the same order outputted by Godoc: https://godoc.org/golang.org/x/tools/cmd/godoc Example: https://golang.org/pkg/os/ Except, put the methods right after the type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same order outputted by Godoc:
https://godoc.org/golang.org/x/tools/cmd/godoc
Example:
https://golang.org/pkg/os/