Fix presence matcher w/ custom serializer #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the presence matcher on an attribute that is defined with `serialize` and using a custom serializer instead of a Rails built-in, the matcher failed spectacularly. This commit fixes that.
mcmire
force-pushed
the
fix-presence-with-custom-serializer
branch
from
aeb605a
to
20e3da3
Compare
stas
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the presence matcher on an attribute that is defined with
serializeand using a custom serializer instead of a Rails built-in,the matcher failed spectacularly. This commit fixes that.