Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop worker_on_boot from puma config #992

Closed
composerinteralia opened this issue Aug 22, 2019 · 3 comments · Fixed by #1024
Closed

Drop worker_on_boot from puma config #992

composerinteralia opened this issue Aug 22, 2019 · 3 comments · Fixed by #1024

Comments

@composerinteralia
Copy link
Contributor

rails/rails#31241 removed the advice to use worker_on_boot in config/puma.rb. I am guessing we can drop that now as well.
@composerinteralia
Copy link
Contributor Author

Or even better, could we use the Heroku plugin mentioned here: https://github.com/puma/puma/blob/master/docs/plugins.md

@composerinteralia
Copy link
Contributor Author

If puma/puma#1949 happens we may be able to drop our config file entirely

@composerinteralia
Copy link
Contributor Author

Looking at this again, the puma configuration that comes with Rails by default now has us covered. We should drop our config entirely.

composerinteralia added a commit that referenced this issue Feb 7, 2020
@composerinteralia @fridaland
Remove custom Puma config
6450269 
Closes #992

Rails now ships with Puma by default, including a default Puma config
that already has everything we need.

Co-authored-by: Frida Casas <frida@thoughtbot.com>
@composerinteralia composerinteralia mentioned this issue Feb 7, 2020
Merged
composerinteralia added a commit that referenced this issue Apr 6, 2020
@composerinteralia @fridaland
Remove custom Puma config
298be6f 
Closes #992

Rails now ships with Puma by default, including a default Puma config
that already has everything we need.

Co-authored-by: Frida Casas <frida@thoughtbot.com>
composerinteralia added a commit that referenced this issue Apr 7, 2020
@composerinteralia @fridaland
Remove custom Puma config
c17b0a1 
Closes #992

Rails now ships with Puma by default, including a default Puma config
that already has everything we need.

Co-authored-by: Frida Casas <frida@thoughtbot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove custom Puma config thoughtbot/suspenders
1 participant
@composerinteralia