Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some spacing and filename in prompt in interactive mode #194

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

dineshba
Copy link
Collaborator

@dineshba dineshba commented Jun 2, 2020

Tried to fix #189

  1. Added some spacing
  2. Filename in the prompt
  3. Header for the interactive mode

@arunvelsriram Please provide your feedback.

Screenshot 2020-06-02 at 9 02 12 PM

Signed-off-by: Dinesh <dineshudt17@gmail.com>
Copy link
Collaborator

@svishwanath-tw svishwanath-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would've been nice

Signed-off-by: Dinesh <dineshudt17@gmail.com>
@dineshba
Copy link
Collaborator Author

dineshba commented Jun 3, 2020

@svishwanath-tw There were some tests. I pushed without fixing it. My bad... Now fixed it. Thanks for the inputs

@svishwanath-tw
Copy link
Collaborator

@arunvelsriram : Does this work for you ?

@svishwanath-tw svishwanath-tw merged commit 83c2c93 into master Jun 8, 2020
@dineshba dineshba deleted the interactive-mode-ux branch June 8, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive mode user experience suggestion
2 participants