Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP scope #367

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Support for PHP scope #367

merged 3 commits into from
Jul 4, 2022

Conversation

vool
Copy link
Contributor

@vool vool commented Jun 10, 2022

Hi,
I am using Talisman on a PHP project, the composer lock file contains lots of hashes which are always ok as it is autogenerated.
Would be great to add support for PHP scope.
Keith

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #367 (33f2096) into master (e50270d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          33       33           
  Lines        1559     1559           
=======================================
  Hits         1087     1087           
  Misses        439      439           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50270d...33f2096. Read the comment docs.

talismanrc/scopes.go Outdated Show resolved Hide resolved
@svishwanath-tw
Copy link
Collaborator

svishwanath-tw commented Jul 3, 2022

I've modified the existing golang scope to remove the vendor folder. #371
I'm unsure if node_modules belongs in the same league.

@vool
Copy link
Contributor Author

vool commented Jul 4, 2022

Yes, I would think so, it is standard to place this under gitignore

I'm unsure if node_modules belongs in the same league.

@svishwanath-tw
Copy link
Collaborator

svishwanath-tw commented Jul 4, 2022

@vool : Please resolve merge conflict. (preferably rebase against thoughtworks:master or at least merge thoughtworks:master into vool:master)

@vool
Copy link
Contributor Author

vool commented Jul 4, 2022

Already up to date.

@vool : Please resolve merge conflict. (preferably rebase against thoughtworks:master or at least merge thoughtworks:master into vool:master)

@svishwanath-tw svishwanath-tw merged commit a2842ee into thoughtworks:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants