Build releases using GoReleaser

[jmatias]

No description provided.

[codecov]

Codecov Report

Merging #375 (04598fe) into master (2bd2e0d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          33       33           
  Lines        1559     1559           
=======================================
  Hits         1087     1087           
  Misses        439      439           
  Partials       33       33           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd2e0d...04598fe. Read the comment docs.

[jmatias]

Fix main.Version reference in goreleaser.yml

[svishwanath-tw]

Would be neat to see how UPX fits into this.

[svishwanath-tw]

@jmatias : Please remove the schema json from the PR.

[svishwanath-tw]

@jmatias : At this point, the only thing preventing approval/merge is the increased binary size on non arm machines. Talisman build scripts used UPX to make the binary as small as can be.
My worry in going ahead is that a lot of github issues will be created asking to reduce the binary size again. Thoughts ?

[jmatias]

@jmatias : At this point, the only thing preventing approval/merge is the increased binary size on non arm machines. Talisman build scripts used UPX to make the binary as small as can be.
My worry in going ahead is that a lot of github issues will be created asking to reduce the binary size again. Thoughts ?

Regardless of GoReleaser, the issue would still be there for ARM (though they are working on it, we could try building the source code from their main branch)

That being said, 8 MB nowadays does not feel like a whole lot — I would argue that it's acceptable for now until we find a way to either tap into the build hooks or do it post release. (And by that I mean just doing an empty release and then writing something ourselves that uploads the binaries).

I vote for keeping the 8 MB binaries for now.