Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Cannot set up talisman hook on repo paths that contain whitespaces. #377

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

jmatias
Copy link
Member

@jmatias jmatias commented Jul 12, 2022

image

The fix is to set IFS to split only on new lines.

image

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #377 (370d128) into master (fe4c766) will not change coverage.
The diff coverage is n/a.

❗ Current head 370d128 differs from pull request most recent head 6035bd8. Consider uploading reports for the commit 6035bd8 to get more accurate results

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          33       33           
  Lines        1559     1559           
=======================================
  Hits         1087     1087           
  Misses        439      439           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4c766...6035bd8. Read the comment docs.

@jmatias jmatias force-pushed the ifs_path_fix branch 3 times, most recently from 4691b8a to 602a765 Compare July 12, 2022 09:39
@jmatias jmatias enabled auto-merge (squash) July 12, 2022 20:04
@jmatias jmatias removed the request for review from svishwanath-tw July 12, 2022 20:05
@jmatias jmatias disabled auto-merge July 12, 2022 20:06
@jmatias jmatias merged commit 2bd2e0d into thoughtworks:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant