Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pnpm-lock.yml to talismanrc #443

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

dougalg
Copy link
Contributor

@dougalg dougalg commented Jan 5, 2024

I'm adding support for pnpm-lock.yml when the node scope is enabled. This could be useful as many people use pnpm and might not want to have to manually ignore it every time the lockfile changes

@dougalg dougalg changed the title Add pnpm.lock to talismanrc test Add pnpm-lock.yml to talismanrc test Jan 8, 2024
@dougalg dougalg changed the title Add pnpm-lock.yml to talismanrc test Add pnpm-lock.yml to talismanrc Jan 8, 2024
@dougalg
Copy link
Contributor Author

dougalg commented Jan 11, 2024

@harinee @jmatias Just wanted to check if there's any extra process I should follow when raising this PR? Should I also open an issue for this, for example?

@dougalg-js-tw
Copy link

cc @tw-owen-nelson

@dougalg-js-tw
Copy link

@jmatias just following up on this again, thanks

@tw-owen-nelson tw-owen-nelson merged commit 636d996 into thoughtworks:main Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants