String changes in internal/polling/polling.go #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important one, from the point of view of human user, is the addition of telling that a maximum retry has been reached. The poll script got rid of the way too long line. That is done by using "iPXE script continueing line character", \, backslash. Poll interval shorter, from ten seconds to seven seconds, also from 10000 ms to more readable 7000 ms (clearly three zeros (how many zeros are in 10000? (four or five?))). Added information about a loop that only looks like a loop. A minor `s/iPXE/iPXE client/`. In directory test/integ-test/expected-results/ are poll-unknown.txt and poll.txt updated for getting a clean `make test`.
In particular, mentioning 'maxRetry' exposes implementation code to the end user, which we should avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important one, from the point of view of human user, is the addition of telling that a maximum retry has been reached.
The poll script got rid of the way too long line. That is done by using "iPXE script continueing line character", , backslash. Poll interval shorter, from ten seconds to seven seconds, also from 10000 ms to more readable 7000 ms (clearly three zeros (how many zeros are in 10000? (four or five?))).
Added information about a loop that only looks like a loop.
A minor
s/iPXE/iPXE client/.In directory test/integ-test/expected-results/ are poll-unknown.txt and poll.txt updated for getting a clean
make test.