-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solving #266 with a new multiprocessing design #268
base: master
Are you sure you want to change the base?
Conversation
…void deprecation warning in Numpy >= 1.20
…. Unified code for ordered and unordered processing
Pull Request Test Coverage Report for Build 912
💛 - Coveralls |
Thank you for the pull request. I think this could work, in fact it does wotk for 'ram' databases. However, switiching dbformat to 'csv' result in an TypeError: cannot pickle". Good news is, we do not need the parallel mode to know anythin about the database. In case we switch to multiprocessing (as proposed here), we would need to hand over the user defined spot_setup class to the ForEach class only. So far it somehow gets to whole _algorithm via self. We might also need some queues for collecting and storing the data. In case we stay with pathos.multiprocessing, we would need to figure out, why the csv database remains empty (happens if I try to reproduce #266). This is a strange error to me, as normal .txt writing does not result in any errors under pathos.multiprocessing in spotpy (tests locally). I guess, we can follow up on both ways, having multiprocessing for pickable models and pathos for not pickable things. Would be nice to get at least one of them to run. |
No description provided.