Exposure fix for PS3EYEDriver in Windows and OSX. #152
Conversation
| @@ -180,7 +180,9 @@ void camera_control_set_parameters(CameraControl* cc, int autoE, int autoG, int | |||
| if (cc->capture) { | |||
| cvReleaseCapture(&cc->capture); | |||
| } | |||
|
|
|||
|
|
|||
| ps3eye_set_parameters(cc->eye, autoG > 0, autoWB > 0, gain, exposure, contrast, brightness); | |||
|
Added some comments, please have a look. Also commented on https://github.com/thp/PS3EYEDriver/pull/4 -- we can/should probably only merge this (and fix the submodule reference to point to the merge commit) once the PS3EYEDriver PR is merged. |
|
I agree that this PR shouldn't be merged yet, if at all. I put it forth mostly as an example of why we need the changes to PS3EYEDriver. Sorry I didn't come right out with that at the beginning. Now that the PS3EYEDriver supports Windows, I think maybe it's a good idea to change |
…ly used when compiling for PS3EYEDriver.
|
This PR now has lots of whitespace changes. Please rebase and squash the commits and make sure you don't have unnecessary whitespace changes (spaces to tabs or vice versa) in there, it makes the diff hard to read. |
|
Before I do that, maybe I can do it better. Where did you get the original values for minimum_exposure and maximum_exposure? And how did you know what transformations to apply when passing parameters to CLEYE? |
|
I think those were determined experimentally by @benniven back in summer 2012, he has written the CL Eye integration for Windows. |
|
I couldn't rebase and squash because of the submodule. Instead I made a new, cleaner PR #162 |
Tracker should now work in low light when using PS3EYEDriver in OSX and Windows. Should close #150