Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes diff table colors and padding #730

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

trevorshannon
Copy link
Contributor

This PR:

  • Adjusts diff highlight colors used in the HTML table diff to match those used on github.com diff views.
  • Includes support for dark mode by specifying alternate colors via the prefers-color-scheme: dark media query.
  • Adds padding to the diff table for improved readability
  • Selectively hides table borders for a cleaner view

The following screenshots were made on MacOS running Chrome.

Before (light mode)

Screen Shot 2022-11-30 at 2 01 41 PM

After (light mode)

Screen Shot 2022-11-30 at 2 01 48 PM

Before (dark mode)

Screen Shot 2022-11-30 at 2 02 32 PM

After (dark mode)

Screen Shot 2022-11-30 at 2 02 08 PM

Fixes #729

@trevorshannon trevorshannon marked this pull request as ready for review November 30, 2022 22:16
@thp thp merged commit 0cbd7fc into thp:master Dec 1, 2022
@thp
Copy link
Owner

thp commented Dec 1, 2022

Nice and clean. Thanks for the screenshots in the description as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HtmlReporter uses invalid css color
2 participants