Add concurrency test #806
Merged
Add concurrency test #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
reviewed
Apr 24, 2024
| def save(self, job, guid, data, timestamp, tries, etag=None): | ||
| # Timestamp, tries and ETag are always ignored |
There was a problem hiding this comment.
Is this an unrelated change that fixes another error?
There was a problem hiding this comment.
Yes, this was missing in the file cache storage as its deprecated, but I was using it to test if minidb was the cause of the threading issues.
|
@thp Not sure if this one is still valuable now the minidb bug is fixes, so I've switched it to just add the concurrency test. |
Threading was the cause of the issue in thp#779, so adding a test that will exercise multi-threading.
thp
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a concurrency test that covers the root cause for #799