Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exceptions thrown #3

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Improve exceptions thrown #3

merged 3 commits into from
Oct 8, 2020

Conversation

yogsototh
Copy link
Contributor

@yogsototh yogsototh requested a review from vemv October 8, 2020 11:46
@yogsototh yogsototh self-assigned this Oct 8, 2020
ereteog
ereteog approved these changes Oct 8, 2020
View reviewed changes
Copy link

@ereteog ereteog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vemv
vemv approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, happy to see this one!

@vemv vemv merged commit ebc3ab4 into master Oct 8, 2020
@vemv vemv deleted the exception-improvement branch October 8, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereteog ereteog ereteog approved these changes

@vemv vemv vemv approved these changes

@gbuisson gbuisson Awaiting requested review from gbuisson

@msprunck msprunck Awaiting requested review from msprunck

Assignees

@yogsototh yogsototh

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogsototh @vemv @ereteog