Math: Added Vector3.setFromEuler(); removed Euler.toVector3() #23494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
commented
Feb 14, 2022
| link.rotation | ||
| .toVector3( _vector ) | ||
| .max( rotationMin ) ); | ||
| link.rotation.setFromVector3( _vector.setFromEuler( link.rotation ).max( rotationMin ) ); |
There was a problem hiding this comment.
/ping @takahirox
-
There does not appear to be a test case for use of
rotationMin/Max. Personally, I do not think it makes sense to clamp Euler angles anyway -- except in very special cases. -
Also unrelated to this PR, I am not sure you want to call
updateMatrixWorld()a few lines later. Maybe useupdateWorldMatrix(), where you can control recursion?
There was a problem hiding this comment.
Thanks for pointing out. Let me take a look closer later...
WestLangley
force-pushed
the
dev-setFromEuler
branch
from
6030c77
to
6ce3832
Compare
WestLangley
commented
Feb 15, 2022
| @@ -403,7 +403,7 @@ function SidebarObject( editor ) { | |||
| } | |||
|
|
|||
| const newRotation = new THREE.Euler( objectRotationX.getValue() * THREE.MathUtils.DEG2RAD, objectRotationY.getValue() * THREE.MathUtils.DEG2RAD, objectRotationZ.getValue() * THREE.MathUtils.DEG2RAD ); | |||
| if ( object.rotation.toVector3().distanceTo( newRotation.toVector3() ) >= 0.01 ) { | |||
| if ( new THREE.Vector3().setFromEuler( object.rotation ).distanceTo( new THREE.Vector3().setFromEuler( newRotation ) ) >= 0.01 ) { | |||
There was a problem hiding this comment.
Unrelated to this PR, this code block instantiates new object frequently. At least it is now more honest about it, and is no worse than before.
Mugen87
approved these changes
Feb 15, 2022
|
Thanks! |
19 tasks
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Mar 1, 2022
Closed
4 tasks
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
Merged
Mugen87
pushed a commit
that referenced
this pull request
Oct 18, 2022
## Description Remove the description of toVector3 from Euler's Chinese document. ## Reason Euler's toVector3 method has been removed (#23494), but the Chinese document still retains the description of the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method parallels the existing
Vector3.setFrom*()methods.Similarly,
Euler.setFromVector3().We also avoid "optional targets" in core. This should have been fixed previously; it was just missed.