Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Coverage Flags to Specific Target #65

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

threeal
Copy link
Owner

@threeal threeal commented Dec 15, 2023

This pull request introduces the following changes:

  • Set coverage flags only to the my_fibonacci_test target.
  • Rebuild source files of the my_fibonacci target instead of linking it to the my_fibonacci_test target. This changes prevent the my_fibonacci target from having coverage flags enabled.
  • Modifies check coverage steps as follows:
    • Removes src/main.cpp file from exclude input, basically include all files but it's safe now because the coverage will only enabled to source files related in testing.
    • Set fail-under-line to be 100, make sure test always covers everything.

It closes #64.

@threeal threeal self-assigned this Dec 15, 2023
@threeal threeal added the build label Dec 15, 2023
@threeal threeal added this to the Version 1.0.0 milestone Dec 15, 2023
@threeal threeal marked this pull request as ready for review December 15, 2023 11:42
@threeal threeal merged commit f3c21d1 into main Dec 15, 2023
2 checks passed
@threeal threeal deleted the limit-coverage-flags branch December 15, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit Coverage Flags to Specific Target
1 participant