Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rain detection #79

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Improve rain detection #79

merged 3 commits into from
Nov 6, 2023

Conversation

wvangerwen
Copy link
Collaborator

fixes #70

bergermeer model had een klein impervious surface op de eerste conenction node staan. Hierdoor zag de 0d1d geen regen op het model. Iets robuuster ingericht. Verder testen op 1d2d testen.
@wvangerwen wvangerwen added this to the release 2023.4 milestone Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #79 (d0eabab) into main (bd213d8) will increase coverage by 0.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   41.82%   41.84%   +0.01%     
==========================================
  Files          48       48              
  Lines        5769     5776       +7     
==========================================
+ Hits         2413     2417       +4     
- Misses       3356     3359       +3     
Files Coverage Δ
..._threedi_tools/core/checks/grid_result_metadata.py 84.48% <72.72%> (-3.76%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wvangerwen wvangerwen merged commit 20a3cb3 into main Nov 6, 2023
3 checks passed
@wvangerwen wvangerwen deleted the improve-rain-detection branch November 6, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rain detection werkt niet altijd
2 participants