Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transaction funding service rounds amounts on testnet #127

Closed
DylanVerstraete opened this issue May 6, 2020 · 1 comment · Fixed by #128
Closed

transaction funding service rounds amounts on testnet #127

DylanVerstraete opened this issue May 6, 2020 · 1 comment · Fixed by #128
Assignees
@DylanVerstraete
Labels
priority_critical type_bug Something isn't working

Comments

@DylanVerstraete
Copy link
Contributor

I installed the transactionfunding service locally on commit: e715f11
I am working on the Jumpscale Libs on commit: threefoldtecharchive/jumpscaleX_libs@825e99f
Stellar sdk version: stellar-sdk (2.2.3)

Connected to my local transaction funding service I cannot reproduce the rounding of amounts when the transaction as xdr comes back from the service.

Things go wrong connected to the testnet service and passing the transaction

  1. outgoing tx to the service
AAAAALX7uq+eXcgHVVKPAjAjscsoT2lnDH4ucBIuB6toxeoiAAAAZAAAC60AAAE9AAAAAQAAAAAAAAAAAAAAAF6yrQ4AAAABAAAAAjspAAAAAAABAAAAAQAAAAC1+7qvnl3IB1VSjwIwI7HLKE9pZwx+LnASLgeraMXqIgAAAAEAAAAAW5hxFJxBvsOK/sZDAOTRJpdvFGScYnInwuPJ2vYXCtsAAAABVEZUAAAAAAA5/GQbeotMseuGw9LomxJQHv5mNT8nihPVgEwpv/efZAAAAAA+n+iYAAAAAAAAAAA=
  1. when it comes back from the service
AAAAAGOSa7nPIbsXi4WIKNV5e8wjPSBe1A5ALdfb58NKMLEfAAAAyAAACy4AAAAVAAAAAQAAAAAAAAAAAAAAAF6yrQ4AAAABAAAAAjspAAAAAAACAAAAAQAAAAC1+7qvnl3IB1VSjwIwI7HLKE9pZwx+LnASLgeraMXqIgAAAAEAAAAAW5hxFJxBvsOK/sZDAOTRJpdvFGScYnInwuPJ2vYXCtsAAAABVEZUAAAAAAA5/GQbeotMseuGw9LomxJQHv5mNT8nihPVgEwpv/efZAAAAAA+n+f4AAAAAQAAAAC1+7qvnl3IB1VSjwIwI7HLKE9pZwx+LnASLgeraMXqIgAAAAEAAAAAFOaJWE/fGKg5larzbZSNG34fnAB2KmsGqouij+q6Qh0AAAABVEZUAAAAAAA5/GQbeotMseuGw9LomxJQHv5mNT8nihPVgEwpv/efZAAAAAAAD0JAAAAAAAAAAAFKMLEfAAAAQNTnDmTSOYRNEWwHHt6/voZRq7iISjVMAN3t8pgLA8ELIsXCWJQ5fNbsjMNZ+b55EMHOtqH5AHeFWWLdU0tY+Qw=

you can see inside the xdr that the amount has changed from 105.066716 to 105.0667
@DylanVerstraete DylanVerstraete mentioned this issue May 6, 2020
Closed
DylanVerstraete added a commit that referenced this issue May 6, 2020
@DylanVerstraete
fix rounding of decimals, closes #127
a62b00a
@DylanVerstraete DylanVerstraete linked a pull request May 6, 2020 that will close this issue
fix rounding of decimals, closes #127 #128
Merged
robvanmieghem added a commit that referenced this issue May 6, 2020
@robvanmieghem
Merge pull request #128 from threefoldfoundation/fix_transaction_fund…
ceaaab7 
…ing_rounding

fix rounding of decimals

closes #127
@robvanmieghem robvanmieghem added priority_critical type_bug Something isn't working labels May 6, 2020
@robvanmieghem robvanmieghem added this to the now milestone May 6, 2020
@robvanmieghem
Copy link
Contributor

deployed on testnet
reopened for verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DylanVerstraete DylanVerstraete

Labels
priority_critical type_bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix rounding of decimals, closes #127 threefoldfoundation/tft-stellar
2 participants
@robvanmieghem @DylanVerstraete