Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple certbots with different providers #1362

Merged
merged 5 commits into from
Dec 9, 2020

Conversation

abom
Copy link
Contributor

@abom abom commented Oct 6, 2020

Description

Allow using certbot with multiple providers e.g. letsencrypt, zerossl, or custom acme servers.

Changes

  • Update nginx sal to allow selecting provider/certbot with custom run command for each implementation.

Related Issues

Blocked on threefoldtech/js-ng#465.

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@codecov-io
Copy link

Codecov Report

Merging #1362 (1d601da) into development (238b13d) will increase coverage by 0.27%.
The diff coverage is 81.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1362      +/-   ##
===============================================
+ Coverage        32.13%   32.40%   +0.27%     
===============================================
  Files              134      134              
  Lines            12902    12975      +73     
===============================================
+ Hits              4146     4205      +59     
- Misses            8756     8770      +14     
Impacted Files Coverage Δ
jumpscale/sals/nginx/nginx.py 85.06% <80.28%> (-2.15%) ⬇️
jumpscale/servers/threebot/threebot.py 70.44% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238b13d...1d601da. Read the comment docs.

@abom abom marked this pull request as ready for review December 9, 2020 08:53
@xmonader xmonader merged commit 132b792 into development Dec 9, 2020
@xmonader xmonader deleted the development_multiple_certbots branch December 9, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants