do hash the shared secret generated to decrypt workloads sensitive in formation #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaibon
requested review from
abom,
m-motawea,
rkhamis,
waleedhammam and
xmonader
as code owners
m-motawea
approved these changes
Oct 14, 2020
zaibon
force-pushed
the
development_devnet
branch
from
beff315
to
f4d153d
Compare
zaibon
force-pushed
the
development_testnet
branch
from
9d8b3f1
to
b344f77
Compare
zaibon
force-pushed
the
development_devnet
branch
from
f4d153d
to
7e45dad
Compare
waleedhammam
approved these changes
Oct 15, 2020
xmonader
reviewed
Oct 15, 2020
…formation Extract from https://en.wikipedia.org/wiki/Elliptic-curve_Diffie%E2%80%93Hellman#Key_establishment_protocol: While the shared secret may be used directly as a key, it can be desirable to hash the secret to remove weak bits due to the Diffie–Hellman exchange.
zaibon
force-pushed
the
development_devnet
branch
from
7e45dad
to
9806008
Compare
xmonader
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from https://en.wikipedia.org/wiki/Elliptic-curve_Diffie%E2%80%93Hellman#Key_establishment_protocol:
DO NOT MERGE YET.