fix issue#3160 #3161
Merged
fix issue#3160 #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameh-farouk
requested review from
abom,
AhmedHanafy725,
arahmanhamdy,
ashraffouda,
dmahmouali,
m-motawea,
OmarElawady,
ranatrk,
rkhamis,
waleedhammam and
xmonader
as code owners
sameh-farouk
force-pushed
the
development-tools-nginx-start-fix-iss3160
branch
from
4d482a4
to
11a1c1e
Compare
sameh-farouk
force-pushed
the
development-tools-nginx-start-fix-iss3160
branch
from
39f16b9
to
873e0fc
Compare
|
What's the behavior if we removed the check cmd? I think it would do this check and see if the process is running, can we test this? |
waleedhammam
approved these changes
Jun 21, 2021
abom
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding extra checks to make sure of the real state of Nginx when threebot server starts.
Changes
is_running() now will check if the PID file specified in the Nginx configuration file Is exists, contains PID that belongs to a running Nginx master process.
Related Issues
#3160
Checklist