add kvstore #1004
Merged
add kvstore #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
force-pushed
the
development-add-kvstore-to-go-client
branch
from
03daef8
to
bb04c00
Compare
Eslam-Nawara
force-pushed
the
development-add-kvstore-to-go-client
branch
from
b00a6af
to
4b29d39
Compare
Eslam-Nawara
requested review from
renauter,
LeeSmet and
sameh-farouk
as code owners
| @@ -1,16 +1,16 @@ | |||
| module github.com/threefoldtech/tfchain/clients/tfchain-client-go | |||
|
|
|||
| go 1.17 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Is there a particular reason to update the MSV?
Given that there haven't been any significant changes, I assume we don't need this.
clients/tfchain-client-go/kvstore.go
Outdated
Comment on lines
138
to
157
| func decodeSecondKey(storageKey types.StorageKey, identity Identity) (key []byte, err error) { | ||
| // remove 16 bytes(32 in hex) pallet and map prefixes. | ||
| // pallet prefix (8 bytes): twox64(pallet_name) | ||
| // map prefix (8bytes) twox64(map_name) | ||
| prefixLen := 32 | ||
|
|
||
| // the storage key contains two keys (AccountID and Vec<u8>) | ||
| // remove the length of the first key(AccountID) | ||
| // the hasher `Blake2_128Concat` includes a 16-byte hash followed by the AccountID | ||
| firstKeyLen := 32 + len(identity.PublicKey()) | ||
|
|
||
| offset := prefixLen + firstKeyLen | ||
|
|
||
| if len(storageKey) < offset { | ||
| return nil, errors.New(fmt.Sprintf("failed to decode second key, storage key len should not be less than %d bytes", offset)) | ||
| } | ||
|
|
||
| err = Decode(storageKey[offset:], &key) | ||
| return key, err | ||
| } |
There was a problem hiding this comment.
Can we move this function to utils.go ?
Eslam-Nawara
force-pushed
the
development-add-kvstore-to-go-client
branch
from
5cfd565
to
1ccac55
Compare
sameh-farouk
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues: