Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow creating a rent contract when node is empty #337

Merged
merged 2 commits into from
Jun 16, 2022
Merged

feat: allow creating a rent contract when node is empty #337

merged 2 commits into from
Jun 16, 2022

Conversation

DylanVerstraete
Copy link
Contributor

@DylanVerstraete DylanVerstraete commented Jun 14, 2022 •
edited
Loading

@gitpod-io
Copy link

gitpod-io bot commented Jun 14, 2022

@DylanVerstraete DylanVerstraete marked this pull request as ready for review June 14, 2022 14:34
LeeSmet
LeeSmet requested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@LeeSmet LeeSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests for creating a rent contract on a node which is in a farm that isn't dedicated, but the node is empty

substrate-node/pallets/pallet-smart-contract/src/lib.rs Outdated Show resolved Hide resolved
@DylanVerstraete DylanVerstraete merged commit c1fd238 into development Jun 16, 2022
@DylanVerstraete DylanVerstraete deleted the feat_rework_rent_contract branch June 16, 2022 15:16
@DylanVerstraete DylanVerstraete mentioned this pull request Jun 16, 2022
Closed
@xmonader xmonader mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSmet LeeSmet LeeSmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanVerstraete @LeeSmet