feat(pallet-tfgrid): allow `hdd only` nodes to register on chain #971

renauter · 2024-05-22T15:36:13Z

Description

We want to allow registration of HDD only nodes on chain for Holochain usage.

Implemented solution:

Similar to what already exists for SSD, add a minimum HDD size requirement on resources.validate_hru()
Then, on validating, make sure node has at least 1 minimum storage capacity available

ensure!(resources.validate_hru() || ensure!(resources.validate_sru() , Error::<T>::InvalidStorageInput);

A "reasonable" minimum HDD size requirement is set to 100 GB (same as SSD).

Please delete options that are not relevant.

substrate-node/pallets/pallet-tfgrid/src/lib.rs

sameh-farouk

LGTM
Thank you

renauter and others added 3 commits May 22, 2024 11:57

feat: validate storage capacity resources

62df060

feat: allow 'hdd only' nodes to register on chain

fb7a5d2

chore: update benchmark weights.rs file for all pallets

4283b58

renauter marked this pull request as ready for review May 28, 2024 15:18

renauter requested review from LeeSmet and sameh-farouk as code owners May 28, 2024 15:18

sameh-farouk requested changes May 28, 2024

View reviewed changes

substrate-node/pallets/pallet-tfgrid/src/lib.rs Outdated Show resolved Hide resolved

renauter and others added 4 commits May 28, 2024 13:35

Trigger CI

6683a4d

keep old errors and add new one at the end

82ecf65

chore: update benchmark weights.rs file for all pallets

4864ce6

Trigger CI

4953d79

renauter requested a review from sameh-farouk May 28, 2024 17:54

sameh-farouk approved these changes May 28, 2024

View reviewed changes

renauter merged commit 3e7c912 into development May 28, 2024
2 checks passed

renauter deleted the feat_allow_hdd_only_nodes_to_register branch May 28, 2024 18:11