Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network changes #460

Merged
merged 7 commits into from
Jan 3, 2020
Merged

Network changes #460

merged 7 commits into from
Jan 3, 2020

Conversation

LeeSmet
Copy link
Contributor

@LeeSmet LeeSmet commented Jan 2, 2020

Might fix #456
Might fix #457

Closes #461
Closes #462

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   39.18%   39.18%           
=======================================
  Files          68       68           
  Lines        4563     4563           
=======================================
  Hits         1788     1788           
  Misses       2525     2525           
  Partials      250      250

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d05f1...58bd546. Read the comment docs.

pkg/network/nr/net_resource.go Outdated Show resolved Hide resolved
pkg/network/ndmz/ndmz.go Outdated Show resolved Hide resolved
pkg/network/nr/net_resource.go Outdated Show resolved Hide resolved
@zaibon
Copy link
Contributor

zaibon commented Jan 2, 2020

@delandtj @LeeSmet can you also explain the reason behing using macvlan instead of veth pair in network resource now.

pkg/network/ndmz/ndmz.go Outdated Show resolved Hide resolved
pkg/network/nr/net_resource.go Outdated Show resolved Hide resolved
@LeeSmet LeeSmet marked this pull request as ready for review January 3, 2020 09:47
@zaibon zaibon merged commit 9af977e into master Jan 3, 2020
@zaibon zaibon deleted the network_changes branch January 3, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants