Always append zinit logs to the end of logfile #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using > to redirect logs, target file offset will be kept even if file is truncated. This result by incoherent/invalid log filesize. Using >> will always append to the end of the file and if logfile is truncated, size will be reset.
maxux
requested review from
delandtj,
LeeSmet,
muhamadazmy and
zaibon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 36.26% 36.27% +0.01%
==========================================
Files 75 75
Lines 5066 5067 +1
==========================================
+ Hits 1837 1838 +1
Misses 2963 2963
Partials 266 266
Continue to review full report at Codecov.
|
|
Good catch ! |
muhamadazmy
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using > to redirect logs, target file offset will be kept even if
file is truncated. This result by incoherent/invalid log filesize.
Using >> will always append to the end of the file and if logfile is
truncated, size will be reset.