gedis: allow to re-use connections from the pool #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that if the MaxIdle is 0, then the connection pool doesn't allow to keep open connection around. Which mean before this change, any time we sent a command, we were creating a new connection from scratch
zaibon
requested review from
delandtj,
LeeSmet,
maxux and
muhamadazmy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
=======================================
Coverage 36.00% 36.00%
=======================================
Files 71 71
Lines 5255 5255
=======================================
Hits 1892 1892
Misses 3093 3093
Partials 270 270
Continue to review full report at Codecov.
|
grimpy
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that if the MaxIdle is 0, then the connection pool
doesn't allow to keep open connection around. Which mean before this
change, any time we sent a command, we were creating a new connection
from scratch