Fixes dangling files in provision cache #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanVerstraete
requested review from
delandtj,
LeeSmet,
maxux,
muhamadazmy and
zaibon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 35.57% 35.51% -0.07%
==========================================
Files 74 74
Lines 5374 5384 +10
==========================================
Hits 1912 1912
- Misses 3189 3198 +9
- Partials 273 274 +1
Continue to review full report at Codecov.
|
zaibon
suggested changes
Mar 23, 2020
pkg/provision/local_store.go
Outdated
| // if a file with size 0 is present we can assume its empty and remove it | ||
| if info.Size() == 0 { | ||
| err := os.Remove(path) | ||
| if err != nil { |
There was a problem hiding this comment.
Seems in both case you do need to return, so you can just do
return os.Remove(path)
zaibon
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.