Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Add rivine Create and Open wallet convenience methods #90

Closed
robvanmieghem opened this issue Aug 24, 2018 · 3 comments
Closed

Add rivine Create and Open wallet convenience methods #90

robvanmieghem opened this issue Aug 24, 2018 · 3 comments
Assignees
Milestone

Comments

@robvanmieghem
Copy link

robvanmieghem commented Aug 24, 2018

No description provided.

@robvanmieghem robvanmieghem changed the title Add rivine Create and Load wallet convenience methods Add rivine Create and Open wallet convenience methods Aug 24, 2018
@ahussein
Copy link

Can you please add more information to the ticket describing what is the purpose of these new methods and how they will be used by client code.

@robvanmieghem
Copy link
Author

robvanmieghem commented Aug 29, 2018

The documentation currently states how to create a wallet

 client_data = {'bc_address': 'https://explorer.testnet.threefoldtoken.com/',
'password_': 'test123',
 'minerfee': 10,
 'nr_keys_per_seed': 5,
 'seed_': seed}

    rivine_client = j.clients.rivine.get('mytestwallet', data=client_data)
    rivine_client.config.save()

or

wallet = RivineWallet(seed=seed,
                                   bc_network='https://explorer.testnet.threefoldtoken.com/',
                                   bc_network_password='test123',
                                   nr_keys_per_seed=5,
                                   minerfee=100000000)

I would like a create wallet that creates and saves it directly, an open wallet method would initiate it based on the saved information

@ahussein
Copy link

merged to development_simple

@ghost ghost removed the state_inprogress label Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants