Workaround ethers import in deployment script for a bug in hardhat-ethers-plugin #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In deployment script we workaround a bug in hardhat-gas-reporter cgewecke/hardhat-gas-reporter#86. For some reason using `hre.ethers` makes gas report broken, the gas usage for functions is not included in the report. This is a problem that shows up in other projects using the deployment scripts of this project, e.g. @keep-network/ecdsa.
pdyraga
approved these changes
May 2, 2022
nkuba
added a commit
to keep-network/keep-core
that referenced
this pull request
May 3, 2022
This version contains improvements from threshold-network/solidity-contracts#100 which help workaround problems with gas reporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround for an issue with
hardhat-gas-reporterplugin (cgewecke/hardhat-gas-reporter#86).When
hre.ethersis used in the deployment script it causes a gas report to be missing executed function's data (example).For tests executed in this repository, reports are fine, but when we use
@threshold-network/solidity-contractsas a dependency in other projects (e.g.@keep-network/ecdsa) it breaks the reports there.