Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAML Support and other fixes #45

Merged
merged 5 commits into from Apr 27, 2017
Merged

XAML Support and other fixes #45

merged 5 commits into from Apr 27, 2017

Conversation

lholota
Copy link
Contributor

@lholota lholota commented Apr 25, 2017

Hi,
I'm trying to use the lib in one of my projects and I've hit some small issues, so I'm sending fixes :)

  • The TabColor property can now be set in XAML (fixed the attached property definition), I also added an example for pure XAML definition
  • Bug fix - when the CurrentPage was changed directly from code by setting the CurrentPage property, the content was changed, but the selected tab in the bottom bar didn't

I am also trying to get the page working with Prism navigation, but that seems to be a bit tougher than I thought, so maybe later...

@lholota
Copy link
Contributor Author

lholota commented Apr 25, 2017

Btw. the latest nuget available at nuget.org doesn't seem to contain the latest version (e.g. the BottomBarPage doesn't have the FixedMode property etc.)

@lazmeister
Copy link
Collaborator

This will resolve our issue too, hopefully, it will be put into the latest!

@lazmeister
Copy link
Collaborator

Hey @lholota I see you forked the repo, I talked to the owners and we should be able to push through some updates via github

@lholota
Copy link
Contributor Author

lholota commented Apr 27, 2017

Cool, nice response time :) I forked it and created a temporary nuget so I could continue with my app, looking forward to the official update

@lazmeister
Copy link
Collaborator

Just waiting on the budget permissions and we should be all set

@lazmeister
Copy link
Collaborator

Nuget*

@lholota lholota deleted the feature/xaml-prism-support branch May 18, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants