Refactoring/remove is empty batch #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
approved these changes
Jun 9, 2024
MischaPanch
approved these changes
Jul 18, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
- Coverage 85.73% 85.71% -0.02%
==========================================
Files 104 104
Lines 8719 8711 -8
==========================================
- Hits 7475 7467 -8
Misses 1244 1244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Keeps the API lean * The same functionality can be achieved using len() on dicts
MischaPanch
force-pushed
the
refactoring/remove_is_empty_batch
branch
from
a503c3e
to
c5dccf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1108
API Update
is_emptyhas been dropped for Batch. Refactoring/remove is empty batch #1144Breaking Changes
Batch.is_emptyhas been removed. Instead, the user can simply check for emptiness of Batch by usinglenon dicts. Refactoring/remove is empty batch #1144