Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dqn tutorial and add envpool to docs #526

Merged
merged 3 commits into from
Feb 14, 2022
Merged

update dqn tutorial and add envpool to docs #526

merged 3 commits into from
Feb 14, 2022

Conversation

gogoduan
Copy link
Contributor

@gogoduan gogoduan commented Feb 12, 2022

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022

Codecov Report

Merging #526 (817a090) into master (d29188e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          63       63           
  Lines        4251     4251           
=======================================
  Hits         4011     4011           
  Misses        240      240           
Flag Coverage Δ
unittests 94.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/buffer/base.py 99.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29188e...817a090. Read the comment docs.

@Trinkle23897 Trinkle23897 changed the title Update dqn.rst update dqn tutorial Feb 14, 2022
@Trinkle23897 Trinkle23897 changed the title update dqn tutorial update dqn tutorial and add envpool to docs Feb 14, 2022
Trinkle23897
Trinkle23897 previously approved these changes Feb 14, 2022
@Trinkle23897 Trinkle23897 merged commit d85bc19 into thu-ml:master Feb 14, 2022
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Co-authored-by: Jiayi Weng <trinkle23897@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants