Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VizDoom PPO example and results #533

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

nuance1979
Copy link
Collaborator

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Replace VizDoom A2C example, which did not work, with PPO, optionally with ICM. Results on D2_navigation and D3_battle are added. ICM helped PPO a little on D2_navigation task, which is closest to the task used in the ICM paper, but not too much. On D3_battle, C51 easily wins over PPO with or without ICM.

@Trinkle23897
Copy link
Collaborator

I only have time next Thursday to fix this annoying issue...

@nuance1979
Copy link
Collaborator Author

I only have time next Thursday to fix this annoying issue...

No problem. Take your time.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #533 (c165c17) into master (23fbc3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          63       63           
  Lines        4306     4306           
=======================================
  Hits         4049     4049           
  Misses        257      257           
Flag Coverage Δ
unittests 94.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23fbc3b...c165c17. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit 97df511 into thu-ml:master Feb 25, 2022
@nuance1979 nuance1979 deleted the vizdoom_ppo branch March 6, 2022 23:14
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
* update vizdoom ppo example

* update README with results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants